-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix support #519
Add nix support #519
Conversation
- Use air as a flake input - Better support developers with a development shell containing dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
@acaloiaro Thanks! Looks great, while I need some time to learn Nix firstly 😄 |
Sounds good @cosmtrek. I'm happy to clarify anything if you have questions. One thing worth considering for this PR is that it serves two uses cases: users and developers. For users it makes For I joined these two user and developer use cases into a single PR, but they could be easy considered in isolation. Selfishly, as a nix user, I want both. But it would be reasonable as a project maintainer to consider them separately. |
9e5e630
to
40688fd
Compare
@@ -1,6 +1,8 @@ | |||
module github.com/air-verse/air | |||
|
|||
go 1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do u change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I forgot this PR was open. I use my fork regularly and update it as needed.
I'm closing this PR for now, as there doesn't seem to be much demand for it.
I'll reopen it if requested.
seems is not out of box
|
No demand for this feature. |
This PR allows
air
to be a Flake input for Nix users who useair
in their Go projects.It also better supports
air
development by providing a development shell that contains all ofair
's developer dependencies.I understand if this is not a priority for this project, and I'll continue maintaining my fork of air at
acaloiaro/air
if you choose not to directly support nix.Cheers!